[SLING-2929] Wasted work in ClassDescriptor.validate()

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Maven JCROCM Plugin 2.0.6
• Component/s: Maven Plugins and Archetypes
• Labels: patch perfomance
• Environment: any
• Assignee: Robert Munteanu
• Reporter: Adrian Nistor
• Created: 21/Jun/13 15:40
• Updated: 22/Jul/13 08:07
• Resolved: 22/Jul/13 08:07

Description

The problem appears in revision 1495454. I attached a one-line patch
that fixes it.

In method "ClassDescriptor.validate", the loop over "children" should
break immediately after "valid" becomes "false". All the iterations
after "valid" becomes "false" do not perform any useful work, at best
they just set "valid" again to "false".

Method "isLive" in class "ResourceResolverContext" has a similar loop
(over "dynamicProviders"), and this loop breaks immediately after
"result" is set to "false", just like in the proposed patch. Other
methods (e.g., "FactoryPreconditions.checkPreconditions",
"JspUtil.checkAttributes", "EclipseJavaCompiler.compile",
"SecondPassVisitor.appendPageDirective") also have similar loops with
similar breaks, just like in the proposed patch.