Sling
  1. Sling
  2. SLING-2327

Visible TODOs in the background servlets console

    Details

    • Type: Bug Bug
    • Status: Reopened
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Extensions
    • Labels:
      None

      Description

      The console plugin of the contrib/extensions/bgservlets displays some ugly TODOs, those should be removed.

      It might also be good to make this plugin optional, in case users want to supply a custom variant.

        Issue Links

          Activity

          Gavin made changes -
          Workflow re-open possible,doc-test-required [ 12787941 ] no-reopen-closed,doc-test-required [ 12790781 ]
          Gavin made changes -
          Workflow no-reopen-closed,doc-test-required [ 12766415 ] re-open possible,doc-test-required [ 12787941 ]
          Gavin made changes -
          Workflow Copy of no-reopen-closed,doc-test-required [ 12762700 ] no-reopen-closed,doc-test-required [ 12766415 ]
          Gavin made changes -
          Workflow no-reopen-closed,doc-test-required [ 12645477 ] Copy of no-reopen-closed,doc-test-required [ 12762700 ]
          Felix Meschberger made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Assignee Bertrand Delacretaz [ bdelacretaz ]
          Hide
          Felix Meschberger added a comment -

          I really meant to remove this functionality: What is the use for it anyway ?

          It doesn't hurt today (except for a few bytes eaten) but it may be confusing.

          So, if there is no clear use and requirement for it, I suggest to just remove it.

          Show
          Felix Meschberger added a comment - I really meant to remove this functionality: What is the use for it anyway ? It doesn't hurt today (except for a few bytes eaten) but it may be confusing. So, if there is no clear use and requirement for it, I suggest to just remove it.
          Hide
          Bertrand Delacretaz added a comment -

          > Disabling the plugin by configuration is IMHO not required because the Web Console is targeted at admins only.

          ok, I see your point - I'll leave the setting in for now, I don't think it hurts to have it.

          Show
          Bertrand Delacretaz added a comment - > Disabling the plugin by configuration is IMHO not required because the Web Console is targeted at admins only. ok, I see your point - I'll leave the setting in for now, I don't think it hurts to have it.
          Hide
          Felix Meschberger added a comment -

          Disabling the plugin by configuration is IMHO not required because the Web Console is targeted at admins only. And those would probably be interested in seeing the background jobs - no matter where they come from.

          Show
          Felix Meschberger added a comment - Disabling the plugin by configuration is IMHO not required because the Web Console is targeted at admins only. And those would probably be interested in seeing the background jobs - no matter where they come from.
          Bertrand Delacretaz made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Bertrand Delacretaz added a comment -

          TODOS removed in revision 1231129.

          Plugin made optional in revision 1231138, can be disabled by configuration.

          The use case for disabling the plugin is when background jobs are user-level operations: our plugin is good enough for admin-level background jobs, but for end users it's good to have a UI that's integrated with the rest of your system's user-level UI.

          That was the whole idea behind the JobConsole service, to be able to create customized consoles, in which case it can be good to disable the webconsole plugin to avoid confusion.

          Show
          Bertrand Delacretaz added a comment - TODOS removed in revision 1231129. Plugin made optional in revision 1231138, can be disabled by configuration. The use case for disabling the plugin is when background jobs are user-level operations: our plugin is good enough for admin-level background jobs, but for end users it's good to have a UI that's integrated with the rest of your system's user-level UI. That was the whole idea behind the JobConsole service, to be able to create customized consoles, in which case it can be good to disable the webconsole plugin to avoid confusion.
          Hide
          Felix Meschberger added a comment -

          > It might also be good to make this plugin optional, in case users want to supply a custom variant.

          Why ? Isn't our plugin good enough ?

          Show
          Felix Meschberger added a comment - > It might also be good to make this plugin optional, in case users want to supply a custom variant. Why ? Isn't our plugin good enough ?
          Bertrand Delacretaz made changes -
          Field Original Value New Value
          Link This issue relates to SLING-550 [ SLING-550 ]
          Bertrand Delacretaz created issue -

            People

            • Assignee:
              Bertrand Delacretaz
              Reporter:
              Bertrand Delacretaz
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:

                Development