[SLING-2080] Minor improvements to authentication [patch]

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: OpenID Authentication 1.0.2, JCR Jackrabbit Access Manager 2.1.0, Form Based Authentication 1.0.2, Auth Core 1.0.6, API 2.2.2
• Fix Version/s: OpenID Authentication 1.0.4, JCR Jackrabbit Access Manager 2.1.2, Form Based Authentication 1.0.4, Auth Core 1.1.0, API 2.2.4
• Component/s: API, Authentication, JCR
• Assignee: Felix Meschberger
• Reporter: Angela Schreiber
• Created: 17/May/11 13:18
• Updated: 31/Jan/12 10:54
• Resolved: 08/Nov/11 07:32

Description

while having a look at the sling authentication code i fixed some javadoc errors, missing annotations and redundant/inconsistent code fragments that i came across... feel free to include the attached patch (or parts of it).

there were two additional things i couldn't resolve:

AbstractAuthenticationHandler#sendValid states: " // expressely tell we have no content but set content type"
did you mean explicitly?

FormAuthenticationHandler#AuthenticationStorage:
in this interface and its implementing class the javadoc is broken and refers to CookieAuthData, CookieAuthenticationHandler, CookieExtractor, SessionExtractor.