[SLING-1710] JobEventHandler: jobs in a waiting state won't be waked up anymore if job.getProperty(EventUtil.PROPERTY_JOB_QUEUE_NAME) != null

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: Event 2.3.0
• Fix Version/s: Event 2.4.0
• Component/s: Extensions
• Assignee: Carsten Ziegeler
• Reporter: Philipp Koch
• Created: 31/Aug/10 11:08
• Updated: 06/Sep/10 14:02
• Resolved: 31/Aug/10 12:20

Description

it may happen that a job (before execution) is put in a waiting state because the maximum parallel job count was reached.
unfortunately, that waiting job won't be notified anymore in case the job is bound to a defined job queue:

1377 if ( job.getProperty(EventUtil.PROPERTY_JOB_QUEUE_NAME) == null )

{ 1378 this.parallelJobCount--; 1379 this.backgroundLock.notify(); 1380 }

couldn't one simply remove the "job.getProperty(EventUtil.PROPERTY_JOB_QUEUE_NAME) == null" check or is there a reason why this check got added?