[SLING-1647] Cleanup Authentication Info constants and implementation

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: JCR Resource 2.0.8, Auth Core 1.0.0, API 2.1.0
• Component/s: API, Authentication, JCR
• Assignee: Felix Meschberger
• Reporter: Felix Meschberger
• Created: 12/Aug/10 07:59
• Updated: 28/Jan/11 09:05
• Resolved: 13/Aug/10 06:58

Description

The constants defined on the AuthenticationInfo class in the Commons Auth bundle should be moved as follows:

USER = "user.name"
to the ResourceResolverFactory interface

PASSWORD = "user.password";
to the ResourceResolverFactory interface

CREDENTIALS = "user.jcr.credentials";
to the JcrResourceResolverFactory interface

In addition support for checking the type of a credentials property is to be removed from the AuthenticationInfo class.

Likewise the following constants currently internal to the JcrResourceResolverFactoryImpl class should be moved:

AUTH_INFO_WORKSPACE = "internal.user.jcr.workspace";
to the JcrResourceResolverFactory interface
and change value to user.jcr.workspace (removing the internal prefix)

SESSION_ATTR_IMPERSONATOR = "impersonator";
to the ResourceResolverFactory interface

Finally the following constant from the ResourceResolverFactory interface should be changed:

SUDO_USER_ID = "sudo.user.id";
change the value to user.impersonation

At the end use constants should be ensured, mostly in the JcrResourceResolverFactoryImpl and JcrResourceResolver classes.