[SLING-1545] ScripteEngineManagerFactory is not thread safe

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Scripting Core 2.0.14
• Fix Version/s: Scripting Core 2.0.14
• Component/s: Scripting
• Assignee: Carsten Ziegeler
• Reporter: Felix Meschberger
• Created: 04/Jun/10 07:40
• Updated: 02/Nov/10 13:21
• Resolved: 19/Oct/10 07:36

Description

The ScriptEngineManagerFactory class is not thread-safe:

• Access to the engineSpiBundles, engineSpiServices fields (lists) are not guarded
• Calls to refreshScriptEngineManager are not guarded

This may cause improper states under certain circumstances.

Accesses to these internal fields and methods should properly be guarded.

In addition, replacement of the List as collection of the SPI bundles and service by Set should be considered.