[SLING-1478] Improve SlingScriptHelper service handling

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Scripting Core 2.0.10
• Fix Version/s: Scripting Core 2.0.14
• Component/s: Scripting
• Assignee: Carsten Ziegeler
• Reporter: Carsten Ziegeler
• Created: 07/Apr/10 15:18
• Updated: 02/Aug/21 16:15
• Resolved: 12/Apr/10 13:34

Description

Felix Meschberger wrote on the Sling dev mailing list:
The ScriptHelper.getService(Class) method of the Scripting Core bundle
implementing the SlingScriptHelper API allows scripts to get access to
OSGi services. This all works perfectly in that the method just forwards
the call through to the framework.

At the end of running the script, the service is then "unget".
Now, the framework will guard access to the service registry and if a
lot of requests are asking for a service while processing the request,
even calling repeatedly for the same service during request processing,
this may result in a contention on the service registry.

I wonder if we could do better with this method by caching the services
not only for the time of processing a component but for longer time,
either during complete request processing or even in a size constrained
cache (of course unregistered services will have to be removed).

Issue Links

• is related to: SLING-10697 Make the ScriptContextProvider use the ServiceCache