Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-1280

Rename methods of (new) AuthenticationHandler interface

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      Currently the AuthenticationHandler interface defines the following methods:

      authenticate - extract credentials from request
      requestAuthentication - ask client for credentials
      dropAuthentication - forget about current credentials

      The authenticate and requestAuthentication names are historic and date back to some internal code at the time where uthenticationHandler did not exist yet.

      IMHO these names are not that good. And since we are defining new API anyway, this might probaby be a good time to rename the methods.

      extractCredentials - extract credentials from request
      requestCredentials - ask client for credentials
      dropCredentials - forget about current credentials

      See also the discussion at http://markmail.org/thread/bocbtx2q5js4i2gf

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            fmeschbe Felix Meschberger
            fmeschbe Felix Meschberger
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment