Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-1250

Changing content loader to use o.a.s.jcr.api 2.0.4 broke a few tests

    XMLWordPrintableJSON

Details

    Description

      After r891573, these tests fail from launchpad/testing:

      > org.apache.sling.launchpad.webapp.integrationtest.HttpPingTest.testWebServerRoot
      > org.apache.sling.launchpad.webapp.integrationtest.InitialContentTest.testIndex
      > org.apache.sling.launchpad.webapp.integrationtest.InitialContentTest.testRootRedirectProperty
      > org.apache.sling.launchpad.webapp.integrationtest.InitialContentTest.testInitialContentA
      > org.apache.sling.launchpad.webapp.integrationtest.InitialContentTest.testInitialContentB

      This is because the dependency from o.a.s.jcr.contentloader to o.a.s.jcr.api was changed from version 2.0.2-incubator to 2.0.4. However, launchpad/bundles/pom.xml includes 2.0.2-incubator of o.a.s.jcr.api, so this is an unresolved import, leading to the failure of initial content loader.

      Simply upgrading launchpad/bundles/pom.xml is insufficient, however, because (per SLING-1052) o.a.s.jcr.api no longer exports the JCR API.

      However, I can't find an OSGi-fied version of the JCR 1.0 API. The patch I'll attach here adds the 2.0 API and fixes the tests, but it doesn't feel right.

      Attachments

        1. SLING-1250.patch
          2 kB
          Justin Edelson

        Activity

          People

            Unassigned Unassigned
            justinedelson Justin Edelson
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: