[SLING-12500] ArtifactId #equals() and #hashCode() should not call #toMvnUrl()

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Feature Model 2.0.0
• Fix Version/s: Feature Model 2.0.2
• Component/s: Feature Model
• Assignee: Julian Sedding
• Reporter: Julian Sedding
• Created: 21/Nov/24 09:26
• Updated: 6 days ago 18:01
• Resolved: 6 days ago 18:01

Description

The implementations of ArtifactId#equals() and ArtifactId#hashCode() both delegate to ArtifactId#toMvnUrl(). This makes these calls unnecessarily expensive, because a StringBuilder is created each time. It would be more efficient to implement these methods based on the fields of ArtifactId.

Issue Links

• links to: GitHub Pull Request #34