[SLING-12442] Regression due to SLING-11299

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Scripting JSP 2.6.0, Scripting JSP 2.6.2
• Fix Version/s: Scripting JSP 2.6.4
• Component/s: Scripting
• Assignee: Julian Sedding
• Reporter: Julian Sedding
• Created: 27/Sep/24 10:24
• Updated: 02/Oct/24 13:58
• Resolved: 02/Oct/24 13:58

Description

The fix for SLING-11299 introduced a regression. With that change, a JSP script is re-compiled whenever an exception occurs during the execution of the script.

To fix the immediate issue, in this ticket, the "improved" error logging will be reverted to what it was before SLING-11299. Restoring this improvement will be covered in a separate ticket.

Re-compilation performs the following (non-atomic/non-synchronized) steps

• delete old java file
• delete old class file
• generate new java file
• compile new java file to class file
• add smap data (java source maps for languages that are converted to java source)
  • write tmp class file with added smap data (non-randomized file name)
  • delete class file
  • move tmp class file to class file path

Any request threads that want to render the same JSP script, and that observe that the class file is missing, will also start recompilation with all steps from above.

This can lead to multiple threads throwing exceptions due to an unexpected state on the file system. Especially under load, it can be difficult for the system to recover from such a situation.

Issue Links

• links to: GitHub Pull Request #11