[SLING-12278] Improve handling of late instantiated context in SlingContextExtension/OsgiContextExtension

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Testing OSGi Mock 3.4.2, Testing Sling Mock 3.5.0
• Component/s: Testing
• Assignee: Stefan Seifert
• Reporter: Konrad Windszus
• Created: 28/Mar/24 18:18
• Updated: 22/Apr/24 15:56
• Resolved: 22/Apr/24 15:55

Description

Currently neither in https://sling.apache.org/documentation/development/osgi-mock.html#junit-5-osgi-context-junit-extension nor in https://sling.apache.org/documentation/development/sling-mock.html#junit-5-sling-context-junit-extension it is mentioned that the context must not be instantiated in @BeforeAll or @BeforeEach as at that point in time the extension has already instantiated another context. Those two contexts may lead to subtle issues (for example if resources are only added in the second context). For a concrete example look at https://github.com/wcm-io/io.wcm.testing.aem-mock/issues/37.

In the best case the JUnit5 extension never creates a context (but only uses the existing instance) or at least creation should be deferred until the Before methods have been executed.

Issue Links

• links to: GitHub Pull Request #159