Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-12162

Update o.a.s.junit.core to jupiter 5.10.1

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • JUnit Core 1.1.6
    • JUnit Core 1.1.8
    • JUnit Core
    • None

    Description

      In the context of PR #20, it turned out that a change between jupiter 5.10.0 and 5.10.1 brakes a test case.

      I have identified the relevant change to be stricter enforcement of a test method predicate. It turns out that we have a meta-test (we're running tests within tests for o.a.s.junit.core) that overrides and inherited test method, but does not itself add the `@Test` annotation on it. That way the test method in question is not found, which fails an assertion that checks if any meta-tests were run.

      cc Ashok Pelluru

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jsedding Julian Sedding
            jsedding Julian Sedding
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment