Sling
  1. Sling
  2. SLING-1213

Filters to support servlet-API-level scope configuration

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Engine 2.2.0
    • Component/s: Engine
    • Labels:
      None

      Description

      Currently the filter.scope supports either

      • component (comparable to <dispatcher>INCLUDE,FORWARD,ERROR</dispatcher> of the servlet API)
        or
      • request (comparable to <dispatcher>REQUEST</dispatcher> of the servlet API)

      In certain cases one wants to have finer control over the filter scopes, e.g. have a filter that would do <dispatcher>REQUEST,FORWARD</dispatcher>, so that the filter is applied first for the request and then again when you do a requestDispatcher.forward().

      Therefore i suggest that the filter.scope should be enhanced as follows:

      • Make filter.scope a multi-value property
      • Add filter scopes: include, forward and error
      • The existing filter scope "component"(quasi an alias for "include,forward,error") should for backward-compatibility not change.
      • Add filter chains for the new filter scopes (don't know if this is needed internally?)

        Issue Links

          Activity

          Mike Pfaff created issue -
          Felix Meschberger made changes -
          Field Original Value New Value
          Link This issue blocks SLING-1140 [ SLING-1140 ]
          Felix Meschberger made changes -
          Assignee Felix Meschberger [ fmeschbe ]
          Felix Meschberger made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s Engine 2.1.2 [ 12315291 ]
          Resolution Fixed [ 1 ]
          Carsten Ziegeler made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Workflow no-reopen-closed,doc-test-required [ 12483460 ] Copy of no-reopen-closed,doc-test-required [ 12764632 ]
          Gavin made changes -
          Workflow Copy of no-reopen-closed,doc-test-required [ 12764632 ] no-reopen-closed,doc-test-required [ 12766193 ]
          Gavin made changes -
          Link This issue blocks SLING-1140 [ SLING-1140 ]
          Gavin made changes -
          Link This issue is depended upon by SLING-1140 [ SLING-1140 ]
          Gavin made changes -
          Workflow no-reopen-closed,doc-test-required [ 12766193 ] re-open possible,doc-test-required [ 12790138 ]
          Gavin made changes -
          Workflow re-open possible,doc-test-required [ 12790138 ] no-reopen-closed,doc-test-required [ 12793131 ]

            People

            • Assignee:
              Felix Meschberger
              Reporter:
              Mike Pfaff
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development