Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-1213

Filters to support servlet-API-level scope configuration

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Engine 2.2.0
    • Component/s: Engine
    • Labels:
      None

      Description

      Currently the filter.scope supports either

      • component (comparable to <dispatcher>INCLUDE,FORWARD,ERROR</dispatcher> of the servlet API)
        or
      • request (comparable to <dispatcher>REQUEST</dispatcher> of the servlet API)

      In certain cases one wants to have finer control over the filter scopes, e.g. have a filter that would do <dispatcher>REQUEST,FORWARD</dispatcher>, so that the filter is applied first for the request and then again when you do a requestDispatcher.forward().

      Therefore i suggest that the filter.scope should be enhanced as follows:

      • Make filter.scope a multi-value property
      • Add filter scopes: include, forward and error
      • The existing filter scope "component"(quasi an alias for "include,forward,error") should for backward-compatibility not change.
      • Add filter chains for the new filter scopes (don't know if this is needed internally?)

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                fmeschbe Felix Meschberger
                Reporter:
                mikep Mike Pfaff
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: