[SLING-11866] WebconsoleConfigurationHandler does not filter out default values coming from ConfigTaskCreator.getDefaultProperties

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Invalid
• Affects Version/s: Installer Configuration Factory 1.4.2
• Component/s: Installer
• Assignee: Unassigned
• Reporter: Konrad Windszus
• Created: 08/May/23 17:56
• Updated: 12/May/23 07:18
• Resolved: 12/May/23 07:17

Description

Although MetatypeHandler.updateConfiguration takes the default configurations identified via ConfigTaskCreator.getDefaultProperties(...) as fourth argument it will never strip those properties from the props to update. Therefore WebconsoleConfigurationHandler.updateConfiguration(...) will only ever strip properties which have
a) a default which is equal to the value to be set and
b) which are not contained in ConfigTaskCreator.getDefaultProperties(...)

b) just seem to be wrong as the logic should rather be:
strip all properties whose value is either equal to the metatype default value or the default value coming from the same named property of the the configuration provided by any of the MERGE_SCHEME configs.

Issue Links

• is caused by: SLING-10771 Support handling of metatype info when merging configurations
• links to: GitHub Pull Request #8