[SLING-11863] AbstractItem#getAncestor interprets the depth argument incorrectly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Testing JCR Mock 1.6.10
• Component/s: Testing
• Assignee: Eric Norman
• Reporter: Eric Norman
• Created: 06/May/23 22:43
• Updated: 19/May/23 10:40
• Resolved: 10/May/23 18:28

Description

The javadocs for "Item javax.jcr.Item.getAncestor(int depth)" describes the depth argument as:

depth = 0 returns the root node of a workspace.
depth = 1 returns the child of the root node along the path to this Item.
depth = 2 returns the grandchild of the root node along the path to this Item.
And so on to depth = n, where n is the depth of this Item, which returns this Item itself.

However, the org.apache.sling.testing.mock.jcr.AbstractItem#getAncestor implementation is using "ResourceUtil.getParent(getPath(), depth)" which interprets the second argument as:

level = 0 returns the path.
level = 1 returns the parent of path, if it exists, null otherwise.
level = 2 returns the grandparent of path, if it exists, null otherwise.

 

Expected:

AbstractItem#getAncestor should resolve the ancestor path as the item depth minus the supplied depth argument.

this.session.getItem(ResourceUtil.getParent(getPath(), getDepth() - depth));

Issue Links

• links to: GitHub Pull Request #19