[SLING-11736] Add "ensure nodes" which should potentially adjust the primary type/mixin types of existing nodes

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Repoinit JCR 1.1.42
• Fix Version/s: Repoinit Parser 1.9.0, Repoinit JCR 1.1.44
• Component/s: Repoinit
• Assignee: Konrad Windszus
• Reporter: Konrad Windszus
• Created: 14/Dec/22 19:11
• Updated: 08/Feb/23 13:30
• Resolved: 12/Jan/23 16:10

Description

Currently "create path ...." is a no-op when the path does already exist (https://github.com/apache/sling-org-apache-sling-jcr-repoinit/blob/9913b787574186a7a31d184480cec3862816438f/src/main/java/org/apache/sling/jcr/repoinit/impl/AclVisitor.java#L191). This is dangerous as then the path might have other primary and mixin types and subsequent calls of "set properties ..." might fail.
Instead the primary type and mixins should potentially be adjusted on existing nodes as well.

This happened in https://github.com/adobe/aem-project-archetype/issues/997#issuecomment-1351895791 which lead to not starting the repository at all.

Issue Links

• causes: SLING-11769 Update to Repoinit Parser 1.9.0
• causes: SLING-11750 Support the new repoinit statements
• relates to: SLING-10463 Repoinit fails to create node if property already exists at the same path
• links to: GitHub Parser PR
• links to: GitHub PR