[SLING-11722] The SlingRequestDispatcher doesn't correctly implement the RequestDispatcher API

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Engine 2.14.0
• Component/s: Engine
• Assignee: Radu Cotescu
• Reporter: Radu Cotescu
• Created: 06/Dec/22 08:58
• Updated: 24/Feb/23 11:11
• Resolved: 21/Feb/23 13:24

Description

The include method [0] has the following important sentence in its documentation:

The ServletResponse object has its path elements and parameters remain unchanged from the caller's. The included servlet cannot change the response status code or set headers; any attempt to make a change is ignored.

However, the SlingRequestDispatcher [1] doesn't enforce this in any way.

[0] - https://docs.oracle.com/javaee/7/api/javax/servlet/RequestDispatcher.html#include-javax.servlet.ServletRequest-javax.servlet.ServletResponse-
[1] - https://github.com/apache/sling-org-apache-sling-engine/blob/bbc6acca70e7a27386f47fa9733af3740985f375/src/main/java/org/apache/sling/engine/impl/request/SlingRequestDispatcher.java#L177

Issue Links

• links to: PR #29