[SLING-11540] Always clear workspace

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Component/s: CI
• Assignee: Konrad Windszus
• Reporter: Konrad Windszus
• Created: 13/Aug/22 16:15
• Updated: 15/Aug/22 07:20
• Resolved: 15/Aug/22 07:20

Description

The build may fail after refactorings as the working directory on the node is not empty prior to the SCM checkout (and some folders are never overwritten by an SCM checkout).
That leads to errors like the following:

....
[INFO] --- apache-rat-plugin:0.14:check (rat-check) @ sling-maven-plugin ---
[WARNING] Files with unapproved licenses:
  parent/target/.plxarc
  parent/target/rat.txt
  relocate/target/.plxarc
  relocate/target/rat.txt
...
[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.14:check (rat-check) on project sling-maven-plugin: Too many files with unapproved license: 1236 See RAT report in: /home/jenkins/jenkins-agent/workspace/odules_sling-maven-plugin_master/jdk_1.8_latest/target/rat.txt -> [Help 1]

(the log is from https://ci-builds.apache.org/job/Sling/job/modules/job/sling-maven-plugin/job/master/129/consoleFull).

This is due to the fact that the modules parent and relocate have been deleted, but their orphaned target directories are not removed and survive a build.

Issue Links

• links to: GitHub PR