[SLING-11458] Regress - "Writer has already been closed" exception in GraphQLServlet

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: GraphQL Core 0.0.4
• Component/s: GraphQL
• Assignee: Andreas Schaefer
• Reporter: Evgeny Tugarev
• Created: 15/Jul/22 21:15
• Updated: 08/Feb/24 18:30
• Resolved: 15/Aug/23 12:48

Description

The GraphQLServlet shouldn't call response.getWriter().flush() as the JsonWriter used by the JsonSerializer implements Closeable and as such closes the Writer.

This causes a "Writer has already been closed" Exception when flush() is called.

This was fixed in commit d27f4bb7 but then this commit: 11c7e389 did undo the fix as now the JsonWriter is closed when existing the try-catch block.

I will undo it and prevent the premature closure as this is causing issues like when the call to this servlet is made through a dispatcher.

Issue Links

• is a clone of: SLING-9626 "Writer has already been closed" exception in GraphQLServlet
• relates to: SLING-12003 The RequestDispatcher should flush the buffer on forward only if the buffer hasn't already been closed
• links to: GitHub Pull Request #29