[SLING-11245] AclUtil.removePolicies(Session, List<String> paths) will fail if no policy exists

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Repoinit JCR 1.1.38
• Fix Version/s: Repoinit JCR 1.1.40
• Component/s: Repoinit
• Assignee: Angela Schreiber
• Reporter: Angela Schreiber
• Created: 04/Apr/22 10:02
• Updated: 11/Jul/22 18:53
• Resolved: 04/Apr/22 15:32

Description

while using

"delete ACL on /some/path"

i noticed that it will fail if there is no policy to remove.

the reason for this is the usage of

AccessControlUtils.getAccessControlList(session, jcrPath);

which may return an applicable policy if no policy exists yet at the given path.
however, a new applicable policy cannot be removed.

note that the other variants to delete a policy are not affected because they only retrieve existing policies.

in order to fix that usage of AccessControlUtils.getAccessControlList(session, jcrPath) should be replaced by a local utility method

getAccessControlList(@NotNull JackrabbitAccessControlManager acMgr, 
                                     @Nullable String path, boolean includeApplicable)

that does not retrieve applicable policies in case of 'includeApplicable' is false.