Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-11125

SlingClient.exists(...) should use expected status in order to support http retries parameters

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Not A Bug
    • Apache Sling Testing Clients 3.0.10
    • None
    • None

    Description

      Currently if tests need to retries on some errors which are likely to happen in clustered setup (AEM in Cloud for example).

      usually the use of "-Dsling.it.http.retriesErrorCodes=401,404,405,429,500,501,503" would include 404 cases.

      The issue is then SlingClient.exists(...) would always fail in case we try to check for "not existing path" as the test would expect also 404 to be returned.

      The current implementation of ServerErrorRetryStrategy support that if the expected values are passed , this would bypass the retriesErrorCodes.

      Thus it would make sense to pass the possible returned code for the request done by SlingClient.exists(...) call.

      Attachments

        Activity

          People

            Unassigned Unassigned
            petitbear68 Thierry Ygé
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h 10m
                1h 10m