[SLING-11113] resource resolver: bloom filter might be out of sync on startup

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Resource Resolver 1.8.2
• Fix Version/s: Resource Resolver 1.8.4
• Component/s: ResourceResolver
• Assignee: Carsten Ziegeler
• Reporter: Julian Reschke
• Created: 02/Feb/22 13:45
• Updated: 02/Jun/23 07:40
• Resolved: 07/Feb/22 12:17

Description

It appears that the bloom filter can be out of sync with the repo on startup.

Upon startup, when not present, it get's created, and updated with all vanity paths found in the repo. If present, it is used as is.

So for a restart of a node, there's a time window (up to save interval of 60s plus downtime) during which the addition of vanity paths will not be reflected in the bloom filter.

Now the bloom filter is only relevant if the number of vanity paths exceeds the maximum number, so this problem might be hard to observe.

AFAIU, the intent of persisting the bloom filter is to avoid the cost of re-filling it on startup. However, we already know that finding the vanity paths (doing the query, getting the resources and processing the properties) is already costly. It's dubious that avoiding the cost of updating the filter helps here.

Proposal: get rid of the persistence of the bloom filter altogether, reducing the complexity of the code significantly.

 

Issue Links

• relates to: SLING-11363 resource resolver: bloom filter incomplete when vanity path size limited
• relates to: SLING-11659 ResourceResolver: remove dead test code related to persisted bloom filter
• links to: https://github.com/apache/sling-org-apache-sling-resourceresolver/commit/6d0550a690bd1d59c136d719a6aedfc014ffae56