[SLING-1111] RhinoJavaScriptEngine does not preserve scope between eval()s

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Scripting JavaScript 2.0.4
• Fix Version/s: Scripting JavaScript 2.0.8
• Component/s: Scripting
• Assignee: Carsten Ziegeler
• Reporter: Vidar Skauge Ramdal
• Created: 16/Sep/09 08:53
• Updated: 20/Sep/17 12:09
• Resolved: 07/Apr/10 12:32

Description

The RhinoJavaScriptEngine does not preserve it scope, so that the scope is reset between each call to eval().

So that:
RhinoJavaScriptEngineFactory factory = new RhinoJavaScriptEngineFactory();
ScriptEngine engine = factory.getScriptEngine();
engine.eval("var f = 1");
engine.eval("f += 1");
... fails with a "ReferenceError: "f" is not defined"

The problem seems to be that "scope" is a local variable in RhinoJavaScriptEngine.eval(), while it should have been a class field.

I have prepared a patch and a test (coming up), but I'm not familiar with the script engine code, so the fix might very likely break other stuff.
So please review this.

More background: http://www.coderanch.com/t/460570/Other-JSE-JEE-APIs/java/javax-script-Save-state-scope