[SLING-11074] Cache model for all of its adapter types

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Component/s: Sling Models
• Assignee: Dirk Rudolph
• Reporter: Dirk Rudolph
• Created: 19/Jan/22 10:37
• Updated: 10/Feb/22 10:51
• Resolved: 10/Feb/22 10:49

Description

Currently the ModelAdapterFactory caches a cacheable model for the requested type only

https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L430-L432

if (result.wasSuccessful() && modelAnnotation.cache() && adaptableCache != null) {
  adaptableCache.put(requestedType, new SoftReference<Object>(result.getValue()));
}

However, if a model is an adapter of multiple types an instance of it can also be returned for more than just the requested type.

Caching the model for each of its adapter types may improve the cache hit ratio.

interface A {}
interface B {}

@Model(cache=true, adaptables=Resource.class, adapters={A.class, B.class})
class Model implements A, B {}

assertSame(givenResource.adaptTo(A.class), givenResource.adaptTo(B.class))

Issue Links

• links to: sling-org-apache-sling-models-impl #32