[SLING-11055] Cleanup Repoinit Parser Code Smells

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: Repoinit Parser 1.6.10
• Fix Version/s: Repoinit Parser 1.6.12
• Component/s: Repoinit
• Assignee: Dan Klco
• Reporter: Dan Klco
• Created: 13/Jan/22 02:27
• Updated: 04/Feb/22 14:04
• Resolved: 27/Jan/22 17:19

Description

There are 31 open code smells identified by SonarQube for the RepoInit Parser:
https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&resolved=false&types=CODE_SMELL

Most are trivial to fix and don't impact the public surface, such as:

• removing unneeded semi-colons
• not specifying second generic parameters
• ensuring assertions are present in all tests
• including the override annotations

There are a few that would either be more difficult to resolve or may change the public surface and therefore aren't going to be addressed in this ticket, specifically:

• code duplication
• avoiding built in exception types
• enum naming