[SLING-1087] RedirectServlet must not redirect if the response is committed or in included requests

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Servlets Get 2.0.4
• Fix Version/s: Servlets Get 2.0.8
• Component/s: Servlets
• Assignee: Felix Meschberger
• Reporter: Felix Meschberger
• Created: 14/Aug/09 19:00
• Updated: 26/Aug/10 20:53
• Resolved: 10/Dec/09 19:37

Description

If a redirect resource is rendered with the RedirectServlet. This servlet should not actually do the redirect if (a) the request has already been committed (to prevent an IllegalStateException) and/or if (b) the request is an included one (we don't expect such things in included requests)

The fix is probably to add such a check at the beginning of the RedirectServlet.doGet method:

if (response.isCommitte())

{ log warn return; } else if (response is included) { log warn return; }

Issue Links

• is duplicated by: SLING-1086 SlingRequestDispatcher must not include redirect resources as is