[SLING-10840] Sling Servlet Helpers implements @ProviderType interfaces

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: Servlet Helpers 1.4.2
• Component/s: General
• Assignee: Unassigned
• Reporter: David Gonzalez
• Created: 27/Sep/21 14:56
• Updated: 20/Oct/21 04:50
• Resolved: 20/Oct/21 04:50

Description

When using the Sling Servlet Helpers bundle/API, code quality scans detect that implentations in the Sling Servlet Helpers bundle implement @ProviderType interfaces from OTHER Sling bundles, which is not correct. Here are some fo the examples (though probably not exhaustive) I found when attempting to use ths Servlet Helpers library.

 

The product interface org.apache.sling.api.request.RequestParameter annotated with @ProviderType should not be implemented by custom code. Detected in org.apache.sling.servlethelpers.MockRequestParameter contained in /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.

The product interface org.apache.sling.api.request.RequestParameterMap annotated with @ProviderType should not be implemented by custom code. Detected in org.apache.sling.servlethelpers.MockRequestParameterMap contained in /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.

The product interface org.apache.sling.api.request.RequestPathInfo annotated with @ProviderType should not be implemented by custom code. Detected in org.apache.sling.servlethelpers.MockRequestPathInfo contained in /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.

The product interface org.apache.sling.api.request.RequestProgressTracker annotated with @ProviderType should not be implemented by custom code. Detected in org.apache.sling.servlethelpers.MockRequestProgressTracker contained in /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.

The product interface org.apache.sling.api.SlingHttpServletRequest annotated with @ProviderType should not be implemented by custom code. Detected in org.apache.sling.servlethelpers.MockSlingHttpServletRequest contained in /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.

The product interface org.apache.sling.api.SlingHttpServletResponse annotated with @ProviderType should not be implemented by custom code. Detected in org.apache.sling.servlethelpers.MockSlingHttpServletResponse contained in /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.

The product interface org.apache.sling.api.resource.Resource annotated with @ProviderType should not be implemented by custom code. Detected in org.apache.sling.servlethelpers.internalrequests.ServletResolutionResource contained in /apps/asset-share-commons-vendor-packages/application/install/org.apache.sling.servlet-helpers-1.4.2.jar.

Perhaps there needs to be Wrappers for all these classes that are @ConsumerTypes?