[SLING-10740] Repoinit create path statement fails for node types with a mandatory property

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Repoinit Parser 1.7.0, Repoinit JCR 1.1.40
• Component/s: Repoinit
• Assignee: Eric Norman
• Reporter: Eric Norman
• Created: 17/Aug/21 21:02
• Updated: 11/Jul/22 18:52
• Resolved: 30/Jun/22 23:42

Description

The processing of the "create path" statement calls save() at the end which will cause a constraint violation if the nodetype of the created path contains any properties that are declared as mandatory (and not autocreated).  No processing of "set properties" statements happens before the save() call in AclVisitor#visitCreatePath so it does not seem to be possible to define any mandatory properties using the current repoinit grammar.

I could see this solved in a couple ways:

1. The AclVisitor#visitCreatePath could possibly pre-process any "set properties" statements that are applicable to the created path before calling save and then skip those same items when NodePropertiesVisitor visits the same.
2. Or, the "create path" grammar could be extended to allow defining properties to be set at the same time as the create (with a syntax that is similar to the "set properties" statement?)
3. Or, perhaps calling save in AclVisitor#visitCreatePath is not necessary?  I'm not sure of the historical reasons why save() is done there.
4. Or, maybe something else I haven't thought of

 

 

Issue Links

• links to: Commit for a test that demonstrates the problem
• links to: JCR RepoInit PR #27
• links to: Repoinit Parser PR #19