[SLING-10571] Hardcoded application paths in VaultPackageUtils.detectPackageType

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: Content-Package to Feature Model Converter
• Labels: technical_debt
• Assignee: Unassigned
• Reporter: Angela Schreiber
• Created: 29/Jun/21 08:23
• Updated: 13/May/22 12:31

Description

while investigating SLING-10467 i noticed hardcoded paths for what should be considered application content in VaultPackageUtils.detectPackageType.

the method looks as follows:

public static @NotNull PackageType detectPackageType(String path) {
        if ("/apps".equals(path)
                || path.startsWith("/apps/")
                || "/libs".equals(path)
                || path.startsWith("/libs/")) {
            return PackageType.APPLICATION;
        } else {
            return PackageType.CONTENT;
        }
    }

instead of hardcoding /apps and /libs which are details of Adobe AEM, these paths should be configured with the converter-launcher. in particular since the list looks a bit arbitrary as there are other paths that IMHO should be considered application content like nodetype registry, namespace registry, privilege registry, service users etc.

Issue Links

• blocks: SLING-10467 Converted content package referres to paths moved to repo-init