Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-10549

Regression: BundleTestsProvider recognizes too many test-classes

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • JUnit Core 1.1.0
    • JUnit Core 1.1.6
    • JUnit Core, Testing
    • None

    Description

      The BundleTestsProvider is responsible for evaluating the Sling-Test-Regexp. With version 1.1.0 a regression was introduced by refactoring from

      Pattern.compile(headerValue).matcher(testName).matches()

      to

      Pattern.compile(headerValue).asPredicate().test(testName)

      This is equivalent to calling Pattern.compile(headerValue).matcher(testName).find(), which returns true on partial matches, while #matches() only returns true for complete matches.

      We should revert to the previous behaviour.

      Attachments

        Activity

          People

            jsedding Julian Sedding
            jsedding Julian Sedding
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: