[SLING-10503] DefaultQueryExecutor should not log the full Schema Definition on error

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: GraphQL Core 0.0.10
• Fix Version/s: GraphQL Core 0.0.12
• Component/s: GraphQL
• Assignee: Bertrand Delacretaz
• Reporter: Denis Moret
• Created: 17/Jun/21 13:55
• Updated: 12/Jul/21 15:37
• Resolved: 22/Jun/21 15:51

Description

If an exception is caught during a query execution, the full schema definition is logged. If the schema is large or if the error is repeating, it might induce a large quantity of logs.

I would suggest to log the schema definition on DEBUG log level only.

https://github.com/apache/sling-org-apache-sling-graphql-core/blob/5d43e133d6c0d29feb7499e28cb9a3f617b5a8a4/src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java#L231

Update: as discussed below we have removed the schema from the logs, as it can be quite big. And added the selectors to log messages, which together with the Resource path allow the schema to be recreated if needed

Issue Links

• links to: GitHub Pull Request #24