[SLING-10403] Converter does not override existing package dependencies when it doesn't have any dependencies

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Content-Package to Feature Model Converter 1.1.0
• Fix Version/s: Content-Package to Feature Model Converter 1.1.2
• Component/s: Content-Package to Feature Model Converter
• Assignee: Karl Pauls
• Reporter: Karl Pauls
• Created: 20/May/21 08:13
• Updated: 24/May/21 21:32
• Resolved: 20/May/21 08:37

Description

We used to not copy the dependencies from the properties of content packages. However, with SLING-10205 we started doing so. That would be fine, as we override the dependencies with the ones we want anyways - however, we don't do that in case we don't have any dependencies:

https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/vltpkg/VaultPackageUtils.java#L93

We need to remove the dependencies key if we don't have any dependencies.

Issue Links

• is caused by: SLING-10205 Support converting packages with custom properties and install hooks
• links to: GitHub Pull Request #84