[SLING-10388] RepoPath.getParent returns null for top-level paths

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Content-Package to Feature Model Converter 1.1.0
• Fix Version/s: Content-Package to Feature Model Converter 1.1.2
• Component/s: Content-Package to Feature Model Converter
• Assignee: Angela Schreiber
• Reporter: Angela Schreiber
• Created: 18/May/21 16:38
• Updated: 24/May/21 21:32
• Resolved: 19/May/21 06:35

Description

kpauls, as discussed it seem there exists one (or potentially many) bugs in the RepoPath class as new RepoPath("/apps").getParent() returns null, which IMHO is unexpected.

more things i noticed while trying to understand what's going on:

• toString for a repository path is "/" and not ""
• equals method ignores isRepositoryPath field
• getSegmentCount is not used at all
• however, getSegments does not exist (but would be better in DefaultAclManager.getCreatePath than the split/substring on the toString method)
• startswith(null(: comment states that the root path is null which is not what the code does in the constructor.... startswith(null) should IMO return false

Issue Links

• Discovered while testing: SLING-10386 Converter needs to issue create path statements for repoinit path without node type
• links to: GitHub Pull Request #80
• links to: GitHub Pull Request #81