[SLING-10339] Execution plan failure for JCR Package Init

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: JCR Package Init 1.0.2
• Fix Version/s: JCR Package Init 1.0.4
• Component/s: Starter
• Assignee: Konrad Windszus
• Reporter: Hans-Peter Stoerr
• Created: 28/Apr/21 09:11
• Updated: 10/Jun/21 09:12
• Resolved: 29/Apr/21 08:03

Description

I am using the feature model content deployment extension to deploy some content packages as a feature using the Sling feature launcher, since the simple ContentPackageHandler of the feature launcher is not able to specify an order in which the content-packages are installed and you have no control over when they are installed (in my case the installation failed since the packages are already installed before the repository was completely initialized with the service user sling-package-install.) However there is a problem with the FSPackageRegistry.contains that prevented this from working when package dependencies are specified in the content-packages: these are checked by ExecutionPlanBuilder as called from ExecutionPlanRepoInitializer, but FSPackageRegistry.contains always returns false since the FSPackageRegistry isn't initialized yet. I reported that as a jackrabbit vault bug, but to make that work with the current version of Jackrabbit Vault I suggest to introduce a workaround: call FSPackageRegistry.packages() before executing the ExecutionPlan to initialize the FSPackageRegistry.

Please note that this needs changing the unittest since the FSPackageRegistry cannot be initialized without setting a homeDir. Perhaps you could just use a Mockito mock instead of an actual FSPackageRegistry. (I could provide a patch if you tell me how to deal with the unittest issue.)

BTW: it took me quite a while to find out that you can specify an installation order for the packages with the content deployment extension by specifying the packages e.g. like that in the feature - it's probably a good idea to mention that in the org.apache.sling.extension.content README.md:

  "content-packages:ARTIFACTS|required": [
    {
      "id": "com.composum.platform:composum-platform-commons-package:zip:${composum.platform.version}",
      "start-order": "31"
    },
    {
      "id": "com.composum.platform:composum-platform-cache-package:zip:${composum.platform.version}",
      "start-order": "31"
    }
  ]

PS: Another think that took me a while to solve is that the bundles that are embedded in the packages get the start level 1. (The same thing happens when you deploy a package with the package manager.) The solution of that was to set the framework property felix.startlevel.bundle to something like 30 - this might even go into the starter.

PS 2: another thing that should be mentioned somewhere is that the feature model content extension has to be in the classpath before the feature launcher since otherwise the standard feature launcher ContentPackageHandler is used.

Issue Links

• relates to: JCRVLT-517 FSPackageRegistry.contains does not initialize packages
• links to: GitHub Pull Request #7