Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-10318

Content Loader - Fix merge and overwrite options

Attach filesAttach ScreenshotAdd voteVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: JCR ContentLoader 2.4.0
    • Fix Version/s: JCR ContentLoader 2.4.4
    • Component/s: JCR
    • Labels:
      None

      Description

      There are 4 boolean flags which influence the import behaviour:

      1. overwrite
      2. overwriteProperties
      3. merge
      4. mergeProperties

      The latter two have been added with SLING-8243. Currently the behaviour differs between JSON and XML Import and also from the Javadoc
      the differences between overwrite and merge are not really clear (https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/master/src/main/java/org/apache/sling/jcr/contentloader/ImportOptions.java).

      For me the flag merge seems a bit misleading, as the javadoc indicates this will replace all old content (nodes and properties or only nodes). Usually when you refer to a merge you also keep some part of the existing content. It seems that merge should rather be named something like replace. WDYT?

        Attachments

        Issue Links

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              kwin Konrad Windszus

              Dates

              • Created:
                Updated:

                Issue deployment