Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-10318

Content Loader - Fix merge and overwrite options

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Major
    • Resolution: Unresolved
    • JCR ContentLoader 2.4.0
    • JCR ContentLoader 2.6.2
    • JCR
    • None

    Description

      There are 4 boolean flags which influence the import behaviour:

      1. overwrite
      2. overwriteProperties
      3. merge
      4. mergeProperties

      The latter two have been added with SLING-8243. Currently the behaviour differs between JSON and XML Import and also from the Javadoc
      the differences between overwrite and merge are not really clear (https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/master/src/main/java/org/apache/sling/jcr/contentloader/ImportOptions.java).

      For me the flag merge seems a bit misleading, as the javadoc indicates this will replace all old content (nodes and properties or only nodes). Usually when you refer to a merge you also keep some part of the existing content. It seems that merge should rather be named something like replace. WDYT?

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              kwin Konrad Windszus
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated: