[SLING-10065] make command servlet tests more robust

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Pipes 4.0.0
• Fix Version/s: Pipes 4.1.2
• Component/s: Extensions
• Assignee: Nicolas Peltier
• Reporter: Nicolas Peltier
• Created: 15/Jan/21 15:43
• Updated: 19/Jan/21 13:48
• Resolved: 15/Jan/21 15:51

Description

sseifert observed a build issue that is probably due to different implementation of EOL in json generation, or/and in test expectation on linux / windows. We should have a more robust way of testing validity of the json response

i've a problem running the unit tests on windows. surefire output see below.
i assume there is a problem with line endings, can you fix the test that it is agnostic of unix/windows line endings?

stefan

-------------------------------------------------------------------------------
Test set: org.apache.sling.pipes.internal.CommandExecutorImplTest
-------------------------------------------------------------------------------
Tests run: 17, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 4.657 s <<< FAILURE! - in org.apache.sling.pipes.internal.CommandExecutorImplTest
org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet  Time elapsed: 0.39 s  <<< FAILURE!
org.junit.ComparisonFailure:
expected:<...:content"],"size":5}[]
> but was:<...:content"],"size":5}[
]
>
        at org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet(CommandExecutorImplTest.java:236)

org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet  Time elapsed: 0.265 s  <<< FAILURE!
org.junit.ComparisonFailure:
expected:<...tent/foo"],"size":1}[]
> but was:<...tent/foo"],"size":1}[
]
>
        at org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet(CommandExecutorImplTest.java:200)

org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand  Time elapsed: 0.263 s  <<< FAILURE!
org.junit.ComparisonFailure:
expected:<...a/carrot"],"size":5}[]
> but was:<...a/carrot"],"size":5}[
]
>
        at org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand(CommandExecutorImplTest.java:225){Quote}