Uploaded image for project: 'Slider'
  1. Slider
  2. SLIDER-1186

Slider incorrectly assumes that keytabs are provided for AM

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • Slider 0.91
    • Slider 0.92
    • appmaster
    • None

    Description

      When the following 2 properties are specified in the app configs, but are set to empty strings, Slider incorrectly assumes that keytabs are provided -

      slider.am.keytab.local.path
      slider.am.login.keytab.name
      

      This should be fixed. Empty strings should be considered equivalent to the absence of the properties.

      Attachments

        1. SLIDER-1186.002.patch
          3 kB
          Gour Saha
        2. SLIDER-1186.001.patch
          3 kB
          Gour Saha

        Activity

          jmaron Jonathan Maron added a comment -

          Looks like rather that trimming you may just be able to get away with a StringUtils.isBlank() check of the returned values?

          jmaron Jonathan Maron added a comment - Looks like rather that trimming you may just be able to get away with a StringUtils.isBlank() check of the returned values?
          gsaha Gour Saha added a comment -

          Thanks jmaron for the prompt review. I uploaded 002 patch incorporating your feedback.

          gsaha Gour Saha added a comment - Thanks jmaron for the prompt review. I uploaded 002 patch incorporating your feedback.
          jmaron Jonathan Maron added a comment -

          LGTM. +1

          jmaron Jonathan Maron added a comment - LGTM. +1

          Commit 0985077198c21cee6789d8413ecfb034e1546764 in incubator-slider's branch refs/heads/develop from gsaha
          [ https://git-wip-us.apache.org/repos/asf?p=incubator-slider.git;h=0985077 ]

          SLIDER-1186 Slider incorrectly assumes that keytabs are provided for AM

          jira-bot ASF subversion and git services added a comment - Commit 0985077198c21cee6789d8413ecfb034e1546764 in incubator-slider's branch refs/heads/develop from gsaha [ https://git-wip-us.apache.org/repos/asf?p=incubator-slider.git;h=0985077 ] SLIDER-1186 Slider incorrectly assumes that keytabs are provided for AM
          gsaha Gour Saha added a comment -

          Thanks jmaron. Committed to develop.

          gsaha Gour Saha added a comment - Thanks jmaron . Committed to develop.

          People

            gsaha Gour Saha
            gsaha Gour Saha
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: