[SLIDER-1157] Code issues - integer handling issues

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Slider 0.91
• Component/s: other
• Assignee: Gour Saha
• Reporter: Gour Saha
• Created: 16/Jul/16 03:02
• Updated: 17/Jul/16 16:07
• Resolved: 17/Jul/16 16:07

Description

Following 2 issues needs to be addressed -

slider-core/src/main/java/org/apache/slider/core/conf/MapOperations.java

325    long totalMinutes = days * 24 * 60 + hours * 24 + minutes;

overflow_before_widen: Potentially overflowing expression hours * 24 with type int (32 bits, signed) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type long (64 bits, signed)

slider-core/src/main/java/org/apache/slider/client/SliderClient.java

1709        if (clusterComponentInstances
1710            .get(clientComponentInstanceEntry.getKey()) == clientComponentInstanceEntry
1711            .getValue()) {

defect: Suspicious comparison of Integer references