[SLIDER-1152] Resource leaks found in code

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Slider 0.91
• Fix Version/s: Slider 0.92
• Component/s: other
• Assignee: Gour Saha
• Reporter: Gour Saha
• Created: 12/Jul/16 22:08
• Updated: 06/Mar/17 21:23
• Resolved: 12/Jul/16 22:15

Description

Resource leaks were found in the following files -

slider-core/src/main/java/org/apache/slider/client/SliderClient.java

1184    IOUtils.write(keystore, new FileOutputStream(storeFile));

leaked_resource: Failing to save or close resource created by new java.io.FileOutputStream(storeFile) leaks it.

slider-core/src/main/java/org/apache/slider/api/proto/RestTypeMarshalling.java

111    InputStream is = new FileInputStream(securityStore.getFile());
112    return IOUtils.toByteArray(is);

noescape: Resource is is not closed or saved in toByteArray.
leaked_resource: Variable is going out of scope leaks the resource it refers to.