Details
Major Description
Most of the time during logging, SIS fetches the logger by a call to Logger.getLogger(String) at each log event. The recommended practice is rather to assign the logger in a static field instead, in order to keep the configuration stable (otherwise the Logger instance may be garbage collected and its configuration lost). It may also have a performance advantage, but uncertain given that the majority of SIS logging are for reporting recoverable exceptions.
We should replace many (not all) calls to Logger.getLogger(String) by static constants. We do not necessarily replace all calls because we do not want to make those loggers visible in public API and we may want to keep the unconditional creation of Logger in e.g. the root of a hierarchy of classes using that logger.