Uploaded image for project: 'Spatial Information Systems'
  1. Spatial Information Systems
  2. SIS-460

Improve exception handling in filters

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Major
    • Resolution: Unresolved
    • 1.1
    • None
    • Features, Storage
    • None

    Description

      In current org.apache.sis.filter implementation, failure to evaluate an expression are caught and logged, then null is returned. For example if the evaluation of A+B fail with an integer overflow, the ArithmeticException is caught and null is returned. We should probably revisit this policy, maybe by letting the exception propagate.

      Expressions and filters are often used for building subsets of FeatureSet. In such case, null values returned from Expression become missing properties in the new Feature instances. We could store the reason for nil values in an characteristic of the missing property. The characteristic name would be a "standard" (for SIS code base) name declared in AttributeConvention.

      The caught exceptions can be located by searching usages of Node.warning(Exception) method.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              desruisseaux Martin Desruisseaux
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: