Uploaded image for project: 'Spatial Information Systems'
  1. Spatial Information Systems
  2. SIS-421

Retrofit WarningListener in a more generic EventListener

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8
    • Fix Version/s: 1.0
    • Component/s: Storage, Utilities
    • Labels:
      None

      Description

      DataStore in SIS 1.0-SNAPSHOT (June 2018) have two kind of listeners:

      • The org.apache.sis.util.logging package defines a WarningListener interface, together with a WarningListeners helper class.
      • The org.apache.sis.storage.event package defines a ChangeListener interface, together with ChangeEvent class. The intent is to have different ChangeEvent subtypes for e.g. structural changes, content changes, etc.

      We should consider renaming the later as StoreListener and StoreEvent, and define a WarningEvent class. The old WarningListener could be replaced by this new mechanism. The intent is to avoid having two listener mechanism in parallel in data stores.

      It seems that WarningListener are currently used only in DataStore, with the exception of org.apache.sis.metadata.sql package. So even if WarningEvent become storage-specific, it may not be a big issue.

        Attachments

          Activity

            People

            • Assignee:
              desruisseaux Martin Desruisseaux
              Reporter:
              desruisseaux Martin Desruisseaux
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: