[SIS-197] Remove the scope of NamedIdentifier, since it duplicates the path

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.4, 0.5
• Fix Version/s: 0.6
• Component/s: Referencing
• Assignee: Martin Desruisseaux
• Reporter: Martin Desruisseaux
• Created: 09/Apr/15 22:33
• Updated: 05/Oct/15 15:35
• Resolved: 09/Apr/15 22:35

Description

The NamedIdentifier(Citation, CharSequence) constructor creates automatically a NameSpace (the value returned by the GenericName.scope() method) based on the Citation title. But this name space is also stored in the head (the value returned by the GenericName.head() method) of the name. This results in duplicated identifier when the full name is printed. For example:

NamedIdentifier name = new NamedIdentifier(Citations.OGC, "scale_factor");
System.out.println( name.toString() );    // Prints "OGC:scale_factor" - duplication is unnoticed.
System.out.println( name.toFullyQualifiedName().toString() );    // Prints "OGC:OGC:scale_factor" - duplication become visible.

The proposed fix is to omit completely the NameSpace creation for automatically generated names. Users can still specify a name space by creating their GenericName explicitly, for example using a NameFactory or the convenience static methods provided in the Names class.