[SIS-195] DefaultResolution(RepresentativeFraction) constructor does not correctly store the given argument

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.5
• Fix Version/s: 0.6
• Component/s: Metadata
• Labels: regression
• Assignee: Martin Desruisseaux
• Reporter: Martin Desruisseaux
• Created: 17/Mar/15 13:36
• Updated: 05/Oct/15 15:39
• Resolved: 17/Mar/15 13:42

Description

Previous SIS version contains the following constructor

    public DefaultResolution(final RepresentativeFraction scale) {
        value = scale;
    }

But as of SIS 0.5, this is no longer sufficient since our new internal implementation requires us to declare if the value is a scale, horizontal distance, vertical distance, angular distance or a text. Since SIS 0.5 forget this declaration, getEquivalentScale() method returns null instead of the given instance.

The fix is to change the implementation as below:

    public DefaultResolution(final RepresentativeFraction scale) {
        if (scale != null) {
            value = scale;
            property = SCALE;
        }
    }

Note that this bug is a SIS 0.5 regression compared to SIS 0.4 and 0.3