[SHIRO-890] Avoid another proxy creator when @EnableAspectJAutoProxy enabled

• Type: Improvement
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.9.1
• Fix Version/s: 2.0.0-alpha, 1.10.0
• Component/s: Integration: Spring
• Assignee: Les Hazlewood
• Reporter: George Cao
• Created: 07/Oct/22 04:00
• Updated: 10/Oct/22 09:29
• Resolved: 07/Oct/22 15:06

Description

There is already an issue created https://issues.apache.org/jira/projects/SHIRO/issues/SHIRO-804.

But when @EnableAspectJAutoProxy enabled, spring actually creates an instance of  AnnotationAwareAspectJAutoProxyCreator but not DefaultAdvisorAutoProxyCreator.  In this situation, there will be two proxy creators in the same context, which leads to methods be proxied twice also .

The fix may remove the type value of the @ConditionalOnMissingBean.

@Bean
@DependsOn("lifecycleBeanPostProcessor")
@ConditionalOnMissingBean(name = AopConfigUtils.AUTO_PROXY_CREATOR_BEAN_NAME)
@Override
public DefaultAdvisorAutoProxyCreator defaultAdvisorAutoProxyCreator() {
    return super.defaultAdvisorAutoProxyCreator();
}
 

Issue Links

• links to: GitHub Pull Request #472
• links to: GitHub Pull Request #474