[SHIRO-751] SimplePrincipalMap and SimplePrincipalCollection throw different exceptions for the same problem

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Resolved
• Fix Version/s: 1.5.3
• Assignee: Unassigned
• Reporter: Hao Zhong
• Created: 28/Mar/20 01:27
• Updated: 03/Apr/20 07:08
• Resolved: 03/Apr/20 07:08

Description

When realname is null, SimplePrincipalCollection throws IllegalArgumentException:

 

public void add(Object principal, String realmName) {
        if (realmName == null) {
            throw new IllegalArgumentException("realmName argument cannot be null.");
        }
        if (principal == null) {
            throw new IllegalArgumentException("principal argument cannot be null.");
        }
        this.cachedToString = null;
        getPrincipalsLazy(realmName).add(principal);
    }

For the same problem, SimplePrincipalMap throws NullPointerException:

 

public Object setRealmPrincipal(String realmName, String principalName, Object principal) { 
 if (realmName == null) { 
   throw new NullPointerException("realmName argument cannot be null."); 
 }
 ...}
 

IllegalArgumentException seems to be more reasonable, and my code currently catches IllegalArgumentException for this type of the problem. Can the SimplePrincipalMap  be modified to throw IllegalArgumentException?

Issue Links

• links to: GitHub Pull Request #208