[SHIRO-747] FirstSuccessfulStrategy doesn't properly short circuit

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Resolved
• Affects Version/s: 1.5.1
• Fix Version/s: 1.5.2
• Assignee: Brian Demers
• Reporter: Tommy Becker
• Created: 11/Mar/20 12:49
• Updated: 24/Jun/20 15:20
• Resolved: 14/Mar/20 07:22

Description

SHIRO-669 supposedly added a method to skip subsequent authentications if one had already succeeded. But it doesn't work; it conditions throwing the ShortCircuitIterationException in beforeAttempt() in part on the PrincipalCollection being empty, which it will (properly) not be if an authentication has succeeded. I believe the check should be that the it is not empty. Was this tested??

Issue Links

• links to: GitHub Pull Request #203