Uploaded image for project: 'Shiro'
  1. Shiro
  2. SHIRO-744

Overlapping classes cause warnings when shading.

    XMLWordPrintableJSON

Details

    Description

      Project has dependecny on shiro-core and shiro-web, no other shiro artifacts.

      When shading (maven plugin) the project WARNING's are emitted:

      [WARNING] shiro-crypto-hash-1.5.1.jar, shiro-core-1.5.1.jar define 24 overlapping classes: 
      [WARNING]   - org.apache.shiro.crypto.hash.format.ProvidedHashFormat
      [WARNING]   - org.apache.shiro.crypto.hash.format.HexFormat
      [WARNING]   - org.apache.shiro.crypto.hash.Sha1Hash
      [WARNING]   - org.apache.shiro.crypto.hash.Md2Hash
      [WARNING]   - org.apache.shiro.crypto.hash.ConfigurableHashService
      [WARNING]   - org.apache.shiro.crypto.hash.HashRequest
      [WARNING]   - org.apache.shiro.crypto.hash.format.Shiro1CryptFormat
      [WARNING]   - org.apache.shiro.crypto.hash.format.HashFormat
      [WARNING]   - org.apache.shiro.crypto.hash.Sha256Hash
      [WARNING]   - org.apache.shiro.crypto.hash.format.DefaultHashFormatFactory
      [WARNING]   - 14 more...
      

      and a 3 way one:

      [WARNING] shiro-config-ogdl-1.5.1.jar, shiro-config-core-1.5.1.jar, shiro-core-1.5.1.jar define 5 overlapping classes: 
      [WARNING]   - org.apache.shiro.config.Ini$1
      [WARNING]   - org.apache.shiro.config.Ini$Section
      [WARNING]   - org.apache.shiro.config.ResourceConfigurable
      [WARNING]   - org.apache.shiro.config.Ini
      [WARNING]   - org.apache.shiro.config.ConfigurationException
      

      Looking in the jars, indeed both shiro-crypto-hash-1.5.1.jar, shiro-core-1.5.1.jar have the same classes. It is as if shiro artifacts include parts of shiro-core that they use.

      Attachments

        Issue Links

          Activity

            People

              fpapon Francois Papon
              andy Andy Seaborne
              Votes:
              2 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: