Uploaded image for project: 'Shiro'
  1. Shiro
  2. SHIRO-629

WildcardPermission syntax

    XMLWordPrintableJSON

    Details

    • Type: Question
    • Status: Open
    • Priority: Critical
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      While looking at the WildcardPermission I see it allows a much wider range of usage then used in all the examples I've seen. Looking at the implementation I notice it is not verifying. I also noted that there is no escaping for matching the [*:,] tokens in the target permission. I think the examples follow the grammar like:

      permission ::= part ( ':' part ) *
      part ::= wildcard | options
      wildcard ::= '*'
      options ::= literal ( ',' literal )
      literal ::= [^*:,]+

      This should disallow permissions like "abc*def", "abc:def,*:foo", "abc:", "x:::::::::::::::". However, the implementation seems to more or less allow anything without warnings or errors. Is this intentional?

      Last, the implementation looks quite expensive since it requires for each construction numerous lists, sets, and arrays. It also executes n*m a regular expression operations for the split. Since the target permission could be constructed frequently since it contains the parameters this is imho very costly.

      Therefore it would be nice if a formal grammar including the character set and escaping.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              pkriens Peter Kriens
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: